[PATCH] D28204: [ValueTracking] use nonnull argument attribute to eliminate null checks

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 4 08:27:46 PST 2017


spatel added inline comments.


================
Comment at: lib/Analysis/ValueTracking.cpp:3409
       } else if (Pred == ICmpInst::ICMP_NE &&
                  match(CmpU, m_Intrinsic<Intrinsic::experimental_guard>()) &&
                  DT->dominates(cast<Instruction>(CmpU), CtxI)) {
----------------
reames wrote:
> Huh, this should really be handling assumes as well.  Can you file a separate bug for that?
I think we can use PR31512 to track this:
https://llvm.org/bugs/show_bug.cgi?id=31512
...but let me know if you think another report is needed.


https://reviews.llvm.org/D28204





More information about the llvm-commits mailing list