[PATCH] D28154: [gtest] Upgrade googletest to version 1.8.0, minimizing local changes.

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: utils/lit/lit/formats/googletest.py:46
         for ln in lines:
-            if not ln.strip():
+            ln = ln.split('#', 1)[0].rstrip()
+            if not ln.lstrip():
----------------
I realize that this may be somewhat obvious, but please add a comment here explaining that this is stripping comments (i.e. everything starting with the first '#') and, more importantly, noting why we don't need to worry about any escaping mechanism here, '#' inside quotes, etc.



================
Comment at: utils/unittest/googletest/include/gtest/gtest-message.h:160
+    // visible via Koenig lookup are both exposed in this function.
+#if 0 // LLVM INTERNAL CHANGE
+    using ::operator <<;
----------------
Shouldn't this be:

  #if GTEST_NO_LLVM_RAW_OSTREAM


================
Comment at: utils/unittest/googletest/include/gtest/gtest-message.h:187
     } else {
-      ::GTestStreamToHelper(ss_.get(), pointer);
+#if 0 // LLVM INTERNAL CHANGE
+      *ss_ << pointer;
----------------
Same here.


https://reviews.llvm.org/D28154