[PATCH] D28169: [ThinLTO] Subsume all importing checks into a single flag

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 22:17:44 PST 2017


mehdi_amini added a comment.

In https://reviews.llvm.org/D28169#634938, @tejohnson wrote:

> Ah ok, that's more than what we do currently. Do you think I should add that to this patch?


Not necessarily: it'd be nice to have such validation of the expected invariant, but I have no idea how much work it is, so if you think you can do it in ~30min, I'd say "yes please", otherwise I would't require it for us to move forward. Sounds reasonable?


https://reviews.llvm.org/D28169





More information about the llvm-commits mailing list