[PATCH] D28247: [DAG] Check for preexisting store when emiting stack convert

[Justin Lebar via Phabricator via llvm-commits]

jlebar added a comment.

This seems sane to me, but I don't quite feel comfortable signing off on it.



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1664
+
+  // Before we allocate space on the stack, see we already have an
+  // equivalent store to another location and leverage that.
----------------
see if we


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1665
+  // Before we allocate space on the stack, see we already have an
+  // equivalent store to another location and leverage that.
+
----------------
location.  If so, use that.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1666
+  // equivalent store to another location and leverage that.
+
+  for (SDNode *U : SrcOp->uses()) {
----------------
No need for a blank line here, since the comment applies just to the loop.


================
Comment at: test/CodeGen/PowerPC/share-bitcast-stores.ll:4
+
+; Verify that bitcasts realized as store-load pairs don't emit extra stores if viable one already exists. 
+
----------------
a viable one


================
Comment at: test/CodeGen/PowerPC/share-bitcast-stores.ll:4
+
+; Verify that bitcasts realized as store-load pairs don't emit extra stores if viable one already exists. 
+
----------------
jlebar wrote:
> a viable one
Please wrap to 80 chars.


https://reviews.llvm.org/D28247