[PATCH] D28245: ADT: IntrusiveRefCntPtr: Broaden the definition of correct usage of RefCountedBase

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 14:32:37 PST 2017


dblaikie updated this revision to Diff 82952.
dblaikie added a comment.

Remove the contentious comment entirely rather than trying to rephrase it.


https://reviews.llvm.org/D28245

Files:
  include/llvm/ADT/IntrusiveRefCntPtr.h


Index: include/llvm/ADT/IntrusiveRefCntPtr.h
===================================================================
--- include/llvm/ADT/IntrusiveRefCntPtr.h
+++ include/llvm/ADT/IntrusiveRefCntPtr.h
@@ -68,9 +68,6 @@
 /// calls to Release() and Retain(), which increment and decrement the object's
 /// refcount, respectively.  When a Release() call decrements the refcount to 0,
 /// the object deletes itself.
-///
-/// Objects that inherit from RefCountedBase should always be allocated with
-/// operator new.
 template <class Derived> class RefCountedBase {
   mutable unsigned RefCount = 0;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28245.82952.patch
Type: text/x-patch
Size: 597 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170103/7c983473/attachment.bin>


More information about the llvm-commits mailing list