[PATCH] D28203: Enable weak hooks on darwin

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubabrecka added a comment.

Looks better, but I'd rather see the list of weak symbols in each subdirectory (`asan/`, `ubsan/`, etc.), because each sanitizer has its own list.  It looks wrong to list sanitizer-specific symbols in a global CMake file.  Can this also be stored in a separate file and not directly in CMake (with a dependency on that file)?

Can we also make the Linux linker use this list?  I only looked briefly at `man ld`, but it seems that `--dynamic-list` may achieve the same?

Overall, I support this change, but I want to avoid situations where a weak symbol is forgotten to be added to the list, and the Linux build will work fine, but Darwin will be broken.


https://reviews.llvm.org/D28203