[PATCH] D27938: [LICM] Report successful hoists/sinks

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 09:50:31 PST 2017


davide requested changes to this revision.
davide added a reviewer: davide.
davide added a comment.
This revision now requires changes to proceed.

I think this needs more tests (a suggestion inline).



================
Comment at: test/Transforms/LICM/opt-remarks.ll:11-16
+  %addr = getelementptr i32, i32* %array, i32 %j
+  %a = load i32, i32* %addr
+; CHECK: remark: /tmp/kk.c:2:20: hosting load
+  %b = load i32, i32* %p, !dbg !8
+  %a2 = add i32 %a, %b
+  store i32 %a2, i32* %addr
----------------
This test is fine but you should add another one where you show up that the remark is emitted when a load is sunk


https://reviews.llvm.org/D27938





More information about the llvm-commits mailing list