[PATCH] D28040: Don't store the NULL DIEs in the DIE array in the DWARFUnit.

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 3 09:40:21 PST 2017


clayborg updated this revision to Diff 82906.
clayborg added a comment.

Updated the DWARF tests to make sure we are testing the parent finding code correctly. The previous test was testing children that were at a depth of 1, but that was a special case in the test where any child with a depth of 1 has a parent of the compile/type unit DIE. By increasing the depth we are now testing the ability to find the parent by looking for the depth that is 1 less than the current depth.


https://reviews.llvm.org/D28040

Files:
  include/llvm/DebugInfo/DWARF/DWARFDebugInfoEntry.h
  include/llvm/DebugInfo/DWARF/DWARFDie.h
  lib/DebugInfo/DWARF/DWARFDie.cpp
  lib/DebugInfo/DWARF/DWARFUnit.cpp
  tools/dsymutil/DwarfLinker.cpp
  unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28040.82906.patch
Type: text/x-patch
Size: 15797 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170103/12afa13b/attachment-0001.bin>


More information about the llvm-commits mailing list