[PATCH] D28181: [MemDep] NFC walk invariant.group graph only down

[Piotr Padlewski via Phabricator via llvm-commits]

Prazek added inline comments.


================
Comment at: test/Transforms/GVN/invariant.group.ll:372-393
+define void @testNotGlobal() {
+   %a = alloca i8
+   call void @foo(i8* %a)
+; CHECK:  %b = load i8, i8* %a, !invariant.group !0
+   %b = load i8, i8* %a, !invariant.group !0
+   call void @foo2(i8* %a, i8 %b)
+
----------------
davide wrote:
> Prazek wrote:
> > davide wrote:
> > > ideally the checks should be auto-generated (many people, me included forget to do so)
> > Excuse me, but I don't understand your comment. Is there anything wrong with my patch, or is it just comment about the perfect world?
> You may want to run `utils/update_test_checks.py` on this to autogenerate checks.
I still don't understand what this script is doing. I runned it, and it only reformatted test (reduced indentation), but non of the check comments have been changed


https://reviews.llvm.org/D28181