[llvm] r290826 - [ValueTracking] remove stale comments; NFC
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 2 11:04:08 PST 2017
Author: spatel
Date: Mon Jan 2 13:04:07 2017
New Revision: 290826
URL: http://llvm.org/viewvc/llvm-project?rev=290826&view=rev
Log:
[ValueTracking] remove stale comments; NFC
The checks were improved with:
https://reviews.llvm.org/rL290194
Modified:
llvm/trunk/lib/Analysis/ValueTracking.cpp
Modified: llvm/trunk/lib/Analysis/ValueTracking.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ValueTracking.cpp?rev=290826&r1=290825&r2=290826&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/ValueTracking.cpp (original)
+++ llvm/trunk/lib/Analysis/ValueTracking.cpp Mon Jan 2 13:04:07 2017
@@ -2542,9 +2542,6 @@ bool llvm::CannotBeNegativeZero(const Va
if (const ConstantFP *CFP = dyn_cast<ConstantFP>(V))
return !CFP->getValueAPF().isNegZero();
- // FIXME: Magic number! At the least, this should be given a name because it's
- // used similarly in CannotBeOrderedLessThanZero(). A better fix may be to
- // expose it as a parameter, so it can be used for testing / experimenting.
if (Depth == MaxDepth)
return false; // Limit search depth.
@@ -2589,9 +2586,6 @@ bool llvm::CannotBeOrderedLessThanZero(c
if (const ConstantFP *CFP = dyn_cast<ConstantFP>(V))
return !CFP->getValueAPF().isNegative() || CFP->getValueAPF().isZero();
- // FIXME: Magic number! At the least, this should be given a name because it's
- // used similarly in CannotBeNegativeZero(). A better fix may be to
- // expose it as a parameter, so it can be used for testing / experimenting.
if (Depth == MaxDepth)
return false; // Limit search depth.
More information about the llvm-commits
mailing list