[PATCH] D28122: RuntimeDyldELF: implement R_AARCH64_PREL64 reloc
Davide Italiano via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 2 06:05:47 PST 2017
davide added a comment.
In https://reviews.llvm.org/D28122#632151, @evgeny777 wrote:
> I've added BE test for PREL64 and BE/LE tests for PREL32 (feature was there already, but wasn't tested)
>
> So currently supported AArch64 relocs are:
> ABS64: LE/BE
> ABS32: LE/BE
> PREL32: LE/BE
> PREL64: LE/BE
> CALL26/JUMP26 : LE
> MOVW_UABS_G3: LE (BE test is incorrect: it passes, but checks for invalid values)
> MOVW_UABS_G2_NC: LE (BE test is incorrect: it passes, but checks for invalid values)
> MOVW_UABS_G1_NC: LE (BE test is incorrect: it passes, but checks for invalid values)
> MOVW_UABS_G0_NC: LE (BE test is incorrect: it passes, but checks for invalid values)
> PREL_PG_HI21: LE (not tested)
> ADD_ABS_LO12_NC: LE
> LDST32_ABS_LO12_NC: LE (not tested)
> LDST64_ABS_LO12_NC: LE (not tested)
>
> Hope this helps
I think we should really clean up all this technical debt before adding other new relocations/features to the JIT.
I think you may want to send reviews for fixing the tests/bugs in the existing BE relocations, add tests for the missing ones and then we can land this one. Thanks for your cooperation.
https://reviews.llvm.org/D28122
More information about the llvm-commits
mailing list