[PATCH] D28118: AVX-512 cost calculation for interleave load/store patterns

[Elena Demikhovsky via Phabricator via llvm-commits]

delena marked 2 inline comments as done.
delena added inline comments.


================
Comment at: ../test/Analysis/CostModel/X86/shuffle-reverse.ll:126
+  ; AVX512F: cost of 2 {{.*}} %V256 = shufflevector
+  ; AVX512BW: cost of 1 {{.*}} %V256 = shufflevector
   %V256 = shufflevector <16 x i16> %src256, <16 x i16> undef, <16 x i32> <i32 15, i32 14, i32 13, i32 12, i32 11, i32 10, i32 9, i32 8, i32 7, i32 6, i32 5, i32 4, i32 3, i32 2, i32 1, i32 0>
----------------
mkuper wrote:
> I thought this patch was not supposed to touch the costs of SK_Reverse shuffles.
> Did we end up considering this shuffle SK_PermuteSingleSrc?
In some cases "reverse" is cheaper in some not, but definitely not more expensive than SK_PermuteSingleSrc. I fixed one line in the  "reverse" cost to make it consistent. But in order to redirect SK_Reverse to SK_PermuteSingleSrc I need to refactor the whole function. I don't want to do this in this patch. I'm also taking in account one more pending patch to the same place: https://reviews.llvm.org/D27811


Repository:
  rL LLVM

https://reviews.llvm.org/D28118