[llvm] r290755 - [NewGVN] Remove unneeded newline from assertion message.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 30 18:50:37 PST 2016


On Fri, Dec 30, 2016 at 3:55 PM, Sean Silva <chisophugis at gmail.com> wrote:
> Why 100? It seems weird to have an `assert` against a magic number like
> this; presumably the assert would fail if the magic number were 2 or
> something? What makes 100 "impossible"? It would be good to have this in a
> comment.
>

I think the number "100" is chosen kinda arbitrarily. Ideally we
shouldn't process every instruction more than an handful of times so
having an instruction processed 100 times is  likely an indication for
bugs. I agree it could be explained in a comment (happy to change),
but I'd like Danny to comment further if 100 was chosen for a
particular reason.

Thanks!

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare


More information about the llvm-commits mailing list