[PATCH] D28184: [doc] Clarify steps for contributors without commit access.

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added inline comments.


================
Comment at: docs/Phabricator.rst:131
 Once a patch has been reviewed and approved on Phabricator it can then be
-committed to trunk.  There are multiple workflows to achieve this. Whichever
-method you follow it is recommend that your commit message ends with the line:
+committed to trunk. If you do not have commit access, somebody else has to
+commit the change for you (with attribution). Usually it is sufficient to add
----------------
somebody -> someone


================
Comment at: docs/Phabricator.rst:132
+committed to trunk. If you do not have commit access, somebody else has to
+commit the change for you (with attribution). Usually it is sufficient to add
+a comment to the approved review indicating you cannot commit the patch
----------------
I would drop the "usually" -- it should always be sufficient to add that comment.


https://reviews.llvm.org/D28184