[llvm] r290765 - DebugInfo: change the PDB UniqueId type to uint8_t

[Saleem Abdulrasool via llvm-commits]

Author: compnerd
Date: Fri Dec 30 13:42:13 2016
New Revision: 290765

URL: http://llvm.org/viewvc/llvm-project?rev=290765&view=rev
Log:
DebugInfo: change the PDB UniqueId type to uint8_t

Since we type-erase the Windows GUID structure, use unsigned bytes
rather than char, which may be signed (-fsigned-char).  NFC

Modified:
    llvm/trunk/include/llvm/DebugInfo/PDB/Raw/RawTypes.h
    llvm/trunk/tools/llvm-pdbdump/PdbYaml.cpp

Modified: llvm/trunk/include/llvm/DebugInfo/PDB/Raw/RawTypes.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/Raw/RawTypes.h?rev=290765&r1=290764&r2=290765&view=diff
==============================================================================
--- llvm/trunk/include/llvm/DebugInfo/PDB/Raw/RawTypes.h (original)
+++ llvm/trunk/include/llvm/DebugInfo/PDB/Raw/RawTypes.h Fri Dec 30 13:42:13 2016
@@ -263,7 +263,7 @@ struct ModuleInfoHeader {
 /// is abstracted here for the purposes of non-Windows platforms that don't have
 /// the GUID structure defined.
 struct PDB_UniqueId {
-  char Guid[16];
+  uint8_t Guid[16];
 };
 
 // The header preceeding the global TPI stream.

Modified: llvm/trunk/tools/llvm-pdbdump/PdbYaml.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbdump/PdbYaml.cpp?rev=290765&r1=290764&r2=290765&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-pdbdump/PdbYaml.cpp (original)
+++ llvm/trunk/tools/llvm-pdbdump/PdbYaml.cpp Fri Dec 30 13:42:13 2016
@@ -57,7 +57,7 @@ template <> struct ScalarTraits<llvm::pd
         Scalar[24] != '-')
       return "GUID sections are not properly delineated with dashes";
 
-    char *OutBuffer = S.Guid;
+    uint8_t *OutBuffer = S.Guid;
     for (auto Iter = Scalar.begin(); Iter != Scalar.end();) {
       if (*Iter == '-' || *Iter == '{' || *Iter == '}') {
         ++Iter;