[PATCH] D28169: [ThinLTO] Subsume all importing checks into a single flag

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: test/ThinLTO/X86/drop-debug-info.ll:5
-; The imported module has out-of-date debug information, let's make sure we can
-; drop them without crashing when materializing later.
 ; RUN: llvm-lto -thinlto-action=import %t.bc -thinlto-index=%t.index.bc -o - | llvm-dis -o - | FileCheck %s
----------------
mehdi_amini wrote:
> tejohnson wrote:
> > mehdi_amini wrote:
> > > I'd be OK to drop this test
> > I'll go ahead and give it the same treatment you did to the other test (using llvm-link).
> That's not equivalent though: the other test was stressing bitcode loading, it could be done equally with llvm-link.
> This test was making sure we correctly "upgrade" the debug info before linking the IR in FunctionImport.cpp (IIRC). Changing to llvm-link won't exercise this code-path and we'll lose this coverage anyway.
> Thinking about it again, we may be able to do it with `opt -functionimport` though
Thinking more, the best would likely be to refactor `llvm-link` to call `FunctionImporter::importFunctions`. It is silly to have this custom logic in llvm-link.


https://reviews.llvm.org/D28169