[PATCH] D28137: [Devirtualization] MemDep returns non-local !invariant.group dependencies

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

The use of a side cache here appears unnecessary.  Why can't you simply return the non-local result to the immediate caller and let it be kept in a local unless needed?

Also, you have a problem with the quality of your results.  You're returning the first non-local found, not the best non-local found.  This makes the results use list order dependent.  We generally try not to have use list order sensitivities in the optimizer.


https://reviews.llvm.org/D28137