[PATCH] D28147: [LICM] Allow promotion of some stores that are not guaranteed to execute
    Michael Kuperstein via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Dec 29 18:01:21 PST 2016
    
    
  
mkuper added a comment.
So, the patch is now fairly small, but I'm having trouble with the testcases.
In particular, I think what we have now is unsound, because isGuaranteedToTransferExecutionToSuccessor() returns true for argmemonly calls, which means that things that should only get promoted with my patch get promoted without.
I'll get back to this on Tuesday. For now, I'll upload the code change, without fixing the tests, in case you want to take a look at the semantic change.
https://reviews.llvm.org/D28147
    
    
More information about the llvm-commits
mailing list