[PATCH] D25428: AMDGPU add support for spilling to a user sgpr pointed buffers

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:103-105
+def int_amdgcn_private_input_ptr :
+  GCCBuiltin<"__builtin_amdgcn_private_input_ptr">,
+  Intrinsic<[LLVMQualPointerType<llvm_i8_ty, 2>], [], [IntrNoMem]>;
----------------
The name shouldn't include private because this is the pointer to the buffer with more than just the private resource descriptor.


================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:156
+   bool isMesaShedOS() const {
+    return TargetTriple.getOS() == Triple::MesaShed;
+  }
----------------
Did you try adding the version number to the end and checking that instead of adding a new OS?


https://reviews.llvm.org/D25428