[PATCH] D28150: Move the section name from GlobalObject to the LLVMContext

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 28 18:29:18 PST 2016


mehdi_amini added inline comments.


================
Comment at: include/llvm/IR/GlobalObject.h:72
+  }
+  StringRef getSection() const {
+    return hasSection() ? getSectionImpl() : StringRef();
----------------
I'd comment here that the access is not efficient and client is advise to check for `hasSection()` before calling it.


https://reviews.llvm.org/D28150





More information about the llvm-commits mailing list