[PATCH] D23114: [PM] Introduce a devirtualization iteration layer for the new PM.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: include/llvm/Analysis/CGSCCPassManager.h:736
+      };
+      bool Devirt = any_of(CallHandles, IsDevirtualizedHandle);
+
----------------
chandlerc wrote:
> mehdi_amini wrote:
> > On the first iteration, it is weird to check all the value handles to find an impossible devirtualized call, but I don't have a better suggestion to reorganize the code that does not make it equally annoying somewhere else...
> It doesn't look impossible to me? We have run the pass once at this point, and had handles held across it. Let me know if I'm missing something here though, happy to look for a better way to structure the code.
Sorry,  I figured after writing this comment but somehow didn't delete it (likely clicked the X instead, which just hide it).

It's all good :)


Repository:
  rL LLVM

https://reviews.llvm.org/D23114