[PATCH] D27993: [libFuzzer] Diff 44 - Update cmake for libFuzzer. Remove requiring LLVM_USE_SANITIZE_COVERAGE .

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a comment.

In https://reviews.llvm.org/D27993#631945, @mpividori wrote:

> In https://reviews.llvm.org/D27993#631931, @kcc wrote:
>
> > In https://reviews.llvm.org/D27993#631795, @mpividori wrote:
> >
> > > @kcc Ok. So, I see two options to achieve both goals:
> > >
> > >   + Force the user to read the docs.
> >
> >
> > Never works.
> >
> > >   + Make it work on Windows (don't use instrumentation for FileCheck target).
> >
> > One option that you proposed off-line is to remove dependency on FileCheck (win-only) and rely on having it in PATH. 
> >  Hacky, but simple.
> >
> > > Or remove these flags, (as this diff does), and add a new cmake flag: `ENABLE_LIBFUZZER` , with default value false.
> >
> > Mmmm. What will it change?
>
>
> By default cmake won't build libFuzzer. So, this will achieve your original intention, users need to read the documentation to build libFuzzer.
>  Also, with the advantage that we don't need `LLVM_USE_SANITIZE_COVERAGE`, so we avoid including instrumentation in all the repository, which is not required for libFuzzer.
>  So, using `ENABLE_LIBFUZZER`, it will work for both, Linux and Windows.
>  I think this is a good solution, since we need a specific flag to enable / disable libFuzzer, independent of `LLVM_USE_SANITIZE_COVERAGE`.


But this will not solve the problem of building the fuzzers in the llvm tree (like clang-fuzzer)


Repository:
  rL LLVM

https://reviews.llvm.org/D27993