[PATCH] D27993: [libFuzzer] Diff 44 - Update cmake for libFuzzer. Remove requiring LLVM_USE_SANITIZE_COVERAGE .

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a comment.

In https://reviews.llvm.org/D27993#631795, @mpividori wrote:

> @kcc Ok. So, I see two options to achieve both goals:
>
>   + Force the user to read the docs.


Never works.

>   + Make it work on Windows (don't use instrumentation for FileCheck target).

One option that you proposed off-line is to remove dependency on FileCheck (win-only) and rely on having it in PATH. 
Hacky, but simple.

> Or remove these flags, (as this diff does), and add a new cmake flag: `ENABLE_LIBFUZZER` , with default value false.

Mmmm. What will it change?

> Or modify `./modules/HandleLLVMOptions.cmake`, to not append "-fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp" when `LLVM_USE_SANITIZE_COVERAGE` is true.

The purpose of LLVM_USE_SANITIZE_COVERAGE is to build the rest of llvm with sanitizer coverage so that we can build things like tools/clang/tools/clang-fuzzer

All this means that we can't bootstrap llvm with asan on windows, right? 
I wonder if someone wants to solve this problem too...


Repository:
  rL LLVM

https://reviews.llvm.org/D27993