[PATCH] D28068: Whenever reasonable, merge ASAN quarantine batches to save memory.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_quarantine.h:151
+    QuarantineBatch *batch_to_deallocate = nullptr;
+    if (list_.empty() || from_cache->list_.empty() ||
+        from_cache->list_.front()->next ||
----------------
is it possible to make a separate function for this part of code and then unit test it? 
(Something like  bool Merge(QuarantineBatch *into, QuarantineBatch *from))


================
Comment at: test/asan/TestCases/Linux/thread_local_quarantine_size_kb.cc:1
 // Test thread_local_quarantine_size_kb
 
----------------
I would suggest to leave this test (mostly?) unchanged and create a new one. 


https://reviews.llvm.org/D28068