[PATCH] D28122: RuntimeDyldELF: implement R_AARCH64_PREL64 reloc

[Davide Italiano via Phabricator via llvm-commits]

davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.

If we support BE, then you should probably add a test which exercises this reloc for a big endian target.
Otherwise, just change that to be LE (if that's the case, ideally, we should change that it everywhere for R_AARCH64*)



================
Comment at: lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:378-380
+    uint64_t Result = Value + Addend - FinalAddress;
+    write(isBE, TargetPtr, Result);
+    break;
----------------
is it possible for this to be big-endian?
i.e. shouldn't this always be `write64le()` as we already do in lld?


https://reviews.llvm.org/D28122