[PATCH] D28137: [Devirtualization] MemDep returns non-local !invariant.group dependencies

Piotr Padlewski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 28 08:23:00 PST 2016


Prazek marked 4 inline comments as done.
Prazek added inline comments.


================
Comment at: lib/Analysis/MemoryDependenceAnalysis.cpp:912
+  {
+    auto NonLocalDef = NonLocalDefsCache.find(QueryInst);
+    if (NonLocalDef != NonLocalDefsCache.end()) {
----------------
davide wrote:
> The type of `NonLocalDef`  is not entirely obvious so I'd prefer if you use the explicit one.
Find returns iterator, so I would like to avoid this long name. Does adding "It" suffix to variable name works for you?


https://reviews.llvm.org/D28137





More information about the llvm-commits mailing list