[PATCH] D28016: [Builtins] [ARM] Adding Thumb1 support for fcmp

[Weiming Zhao via Phabricator via llvm-commits]

weimingz added inline comments.


================
Comment at: lib/builtins/arm/comparesf2.S:243
+    lsls    r3,         r1, #1
+    movs    r0,         #0
+#if __ARM_ARCH_ISA_THUMB == 1
----------------
compnerd wrote:
> Did we set the condition flags previously?
thumb1 has to use the "s" suffixed instructions. The flags will be reset by the "cmp" anyway, so won't affect the correctness. 


https://reviews.llvm.org/D28016