[PATCH] D27993: [libFuzzer] Diff 44 - Update cmake for libFuzzer. Remove requiring LLVM_USE_SANITIZE_COVERAGE .

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 27 11:11:52 PST 2016


kcc added a comment.

I'd love to get rid of these extra cmake flags, but I am not sure this is the right time.
Now, we also require that the host compiler is a fresh clang (preferably, from the same revision) and we have no way to enforce that. 
So these pesky cmake flags "kind of" protect us accidentally using a non-fresh-clang host compiler (because they force the user to read the docs)



================
Comment at: lib/Fuzzer/test/CMakeLists.txt:35
 
+if(NOT "${LLVM_USE_SANITIZER}" STREQUAL "Address")
+  # Enable Address sanitizer.
----------------
Why not add -fsanitize=address unconditionally? 


Repository:
  rL LLVM

https://reviews.llvm.org/D27993





More information about the llvm-commits mailing list