[PATCH] D27133: Introduce element-wise atomic memcpy and memmove intrinsics

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a reviewer: efriedma.
efriedma added a comment.

LGTM with one minor tweak.

Please send an email to llvmdev with a short summary of the feature and a link to this review before you merge this; there might be other people interested in this who don't read llvm-commits.



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4929
+        RTLIB::getMEMCPY_ELEMENT_ATOMIC(ElementSizeConstant);
+    assert(LibraryCall != RTLIB::UNKNOWN_LIBCALL && "Unsupported element size");
+
----------------
This should probably be a report_fatal_error rather than an assertion, given that it can be triggered with valid IR.


https://reviews.llvm.org/D27133