[PATCH] D28115: RuntimeDyldELF: add support for R_AARCH64_ADD_ABS_LO12_NC

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

The code looks correct, but I left a comment inline.



================
Comment at: lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:460-464
+    // Immediate goes in bits 21:10 of LD/ST instruction, taken
+    // from bits 11:0 of X
+    *TargetPtr |= ((Result & 0xfff) << 10);
+    break;
+  }
----------------
This is correct, but while you're here, I'd rather see if you can have a common helper for all the relocations updating immediates in AArch64 instructions (e.g., ldr, str) as we do in lld (see `or32AArch64Imm`).


Repository:
  rL LLVM

https://reviews.llvm.org/D28115