[PATCH] D27522: [X86] Don't allow floating-point return types when SSE[12] is disabled

[Visoiu Mistrih Francis via Phabricator via llvm-commits]

thegameg added a comment.

In https://reviews.llvm.org/D27522#630412, @joerg wrote:

> There are two issues here. First of all, it is missing a test case.


There are already tests on this, but now it shows up in clang as just a diagnostic instead of a crash.

nosse-error1.ll <https://github.com/llvm-mirror/llvm/blob/93e6e5414ded14bcbb233baaaa5567132fee9a0c/test/CodeGen/X86/nosse-error2.ll>
nosse-error2.ll <https://github.com/llvm-mirror/llvm/blob/93e6e5414ded14bcbb233baaaa5567132fee9a0c/test/CodeGen/X86/nosse-error2.ll>

> The second issue is that I somewhat don't like the local diagnose_fatal_error definition, I wonder if SDAG should provide such a helper in general.

I see. Should I just inline the code for each call?

Also, should FastISel be handling this too ?


https://reviews.llvm.org/D27522