[PATCH] D27901: [X86][[AVX512] Code size reduction in X86 by replacing EVEX with VEX encoding

[Zvi Rackover via Phabricator via llvm-commits]

zvi added inline comments.


================
Comment at: lib/Target/X86/X86EvexToVex.cpp:118
+      // Check for EVEX instructions only.
+      if ((Desc.TSFlags & X86II::EncodingMask) != X86II::EVEX)
+        continue;
----------------
I think these 3 if's belong in CompressEvexToVexImpl()


================
Comment at: lib/Target/X86/X86EvexToVex.cpp:165
+      (!(Desc.TSFlags & X86II::EVEX_L2) && (Desc.TSFlags & X86II::VEX_L));
+
+  unsigned NewOpc = 0;
----------------
assert here that (IsEVEX_V128  XOR IsEVEX_V256) ?


================
Comment at: lib/Target/X86/X86EvexToVex.cpp:165
+      (!(Desc.TSFlags & X86II::EVEX_L2) && (Desc.TSFlags & X86II::VEX_L));
+
+  unsigned NewOpc = 0;
----------------
zvi wrote:
> assert here that (IsEVEX_V128  XOR IsEVEX_V256) ?
Please ignore my other comment on this line, Phabricator won't let me remove it.


Repository:
  rL LLVM

https://reviews.llvm.org/D27901