[PATCH] D27901: [X86][[AVX512] Code size reduction in X86 by replacing EVEX with VEX encoding

Gadi Haber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 24 23:27:09 PST 2016


gadi.haber marked an inline comment as done.
gadi.haber added inline comments.


================
Comment at: lib/Target/X86/X86EvexToVex.cpp:111
+  for (MachineBasicBlock &MBB : MF)
+    rc = CompressEvexToVexImpl(MBB);
+
----------------
craig.topper wrote:
> Don't we need to OR into rc? This just captures the last returned value.
Good catch!
Here is the modified code:

```

bool Changed = false;

  /// Go over all basic blocks in function and replace
  /// EVEX encoded instrs by VEX encoding when possible.
  for (MachineBasicBlock &MBB : MF)
    Changed |= CompressEvexToVexImpl(MBB);

  return Changed;
```


Repository:
  rL LLVM

https://reviews.llvm.org/D27901





More information about the llvm-commits mailing list