[llvm] r290506 - MetadataLoader: add an extra assertion in Placeholders flush (NFC)

[Mehdi Amini via llvm-commits]

Author: mehdi_amini
Date: Sat Dec 24 21:55:53 2016
New Revision: 290506

URL: http://llvm.org/viewvc/llvm-project?rev=290506&view=rev
Log:
MetadataLoader: add an extra assertion in Placeholders flush (NFC)

We don't expect any forward reference at this point.

Modified:
    llvm/trunk/lib/Bitcode/Reader/MetadataLoader.cpp

Modified: llvm/trunk/lib/Bitcode/Reader/MetadataLoader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Reader/MetadataLoader.cpp?rev=290506&r1=290505&r2=290506&view=diff
==============================================================================
--- llvm/trunk/lib/Bitcode/Reader/MetadataLoader.cpp (original)
+++ llvm/trunk/lib/Bitcode/Reader/MetadataLoader.cpp Sat Dec 24 21:55:53 2016
@@ -374,12 +374,12 @@ DistinctMDOperandPlaceholder &Placeholde
 
 void PlaceholderQueue::flush(BitcodeReaderMetadataList &MetadataList) {
   while (!PHs.empty()) {
-    auto *MD = MetadataList.getMetadataFwdRef(PHs.front().getID());
+    auto *MD = MetadataList.lookup(PHs.front().getID());
+    assert(MD && "Flushing placeholder on unassigned MD");
 #ifndef NDEBUG
-    if (auto MDN = dyn_cast<MDNode>(MD)) {
+    if (auto *MDN = dyn_cast<MDNode>(MD))
       assert(MDN->isResolved() &&
              "Flushing Placeholder while cycles aren't resolved");
-    }
 #endif
     PHs.front().replaceUseWith(MD);
     PHs.pop_front();