[PATCH] D28091: Add a class to create a tar archive file.

[Sean Silva via Phabricator via llvm-commits]

silvas added a comment.

This is a good idea. Tar is a much more common format that users will be more familiar with. I'm not an expert on Tar files, so I can't review that part of the patch, but hopefully the bots will show if any tar implementations don't like the files we produce.

Sorry, I know this is a bit unrelated to this patch per se, but one thing that has always bothered me is that `--reproduce foo` doesn't produce a file called `foo`; this is very non-unixy. I think it sort of made sense for cpio since that is a less known format, but I think that .tar is common enough that we can expect people to write `--reproduce foo.tar`. That makes any examples self-documenting (users will read `--reproduce repro.tar` and understand that it creates a tar file; rather than `--reproduce repro` and not know what file format it is). What do you think?


https://reviews.llvm.org/D28091