[PATCH] D28076: [PM] Add support for building a default AA pipeline to the PassBuilder.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 24 08:45:35 PST 2016


davide added inline comments.


================
Comment at: lib/Passes/PassBuilder.cpp:1115-1119
+  // manager with our default one.
+  if (PipelineText == "default") {
+    AA = buildDefaultAAPipeline();
+    return true;
+  }
----------------
chandlerc wrote:
> davide wrote:
> > We need similar logic in lld (we already have a flag, `-lto-newpm-aa-pipeline=`. 
> Cool! Thanks for the review, and if someone doesn't beat me to it I'll but adding use of this to LLD in my queue.
We call the same function (from `lib/LTO`), so I don't think any real modification is required, but, yeah, adding a test to lld would be cool (or `llvm-lto2`), if you get to it.


Repository:
  rL LLVM

https://reviews.llvm.org/D28076





More information about the llvm-commits mailing list