[PATCH] D28085: llvm-objdump: sort phdr strings and add PT_NOTE

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

In https://reviews.llvm.org/D28085#630627, @emaste wrote:

> > For 2), please add a test and I'll take another look.
>
> I couldn't find any existing examples of similar tests - we need a linked binary here so we have phdrs. Do you have any suggestions? We could make use of lld perhaps?


I don't think it's reasonable to call lld in the test as it's a subproject and that would violate the property of llvm test suite being self-contained. When I had to deal with this in the past I checked in a binary or used `yaml2obj` to craft an object. If you go for 1) I recommend to add precise instructions on how you created the binary (i.e. source code + clang/lld invocation etc..)


https://reviews.llvm.org/D28085