[PATCH] D28092: [ELF] - Specify -section argument for objdump calls in testcases.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 24 04:05:36 PST 2016


grimar added a comment.

In https://reviews.llvm.org/D28092#630613, @davide wrote:

> I don't quite understand the rationale behind this patch. You tried something to speed up which didn't work, so maybe you want to try profiling `llvm-objdump` and see where the time is spent and try to optimize that instead of landing this patch? Also, did you profile the tests execution and actually found out objdump is the real bottleneck? Keep in mind running LLVM tests on Windows is notoriously slower than on *NIX.


I am mostly suggest this for consistency. We already use -section argument in many tests. That also has a positive effect when need to debug testcase for some reason. I mean reducing output of sections content is still usefull to have.

I did not try to profile the tests yet, just checked that idea as supposed that probably can change something.


https://reviews.llvm.org/D28092





More information about the llvm-commits mailing list