[PATCH] D28079: [GlobalISel] Add support for indirectbr

[Diana Picus via Phabricator via llvm-commits]

rovka added a comment.

Hi,

I'd also add a test case to arm64-instructionselect.mir.
I'm not aware of any end-to-end tests for global-isel on AArch64, but it's not too late to start adding some. Maybe @qcolombet, @ab or @t.p.northover can chime in on this?

Diana



================
Comment at: lib/CodeGen/GlobalISel/MachineIRBuilder.cpp:160
+MachineInstrBuilder MachineIRBuilder::buildBrIndirect(unsigned Tgt) {
+  return buildInstr(TargetOpcode::G_BRINDIRECT).addReg(Tgt);
+}
----------------
Nit: I think addUse would be more consistent with the rest of the file.


================
Comment at: lib/Target/AArch64/AArch64InstructionSelector.cpp:563
+    I.setDesc(TII.get(AArch64::BR));
+    return true;
+  }
----------------
constrainSelectedInstRegOperands?


https://reviews.llvm.org/D28079