[llvm] r290378 - [MIRParser] Fix a typo in comment and error message.
Quentin Colombet via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 22 13:56:35 PST 2016
Author: qcolombet
Date: Thu Dec 22 15:56:35 2016
New Revision: 290378
URL: http://llvm.org/viewvc/llvm-project?rev=290378&view=rev
Log:
[MIRParser] Fix a typo in comment and error message.
We have long switched from size to type.
Added:
llvm/trunk/test/CodeGen/MIR/X86/unexpected-type-phys.mir
- copied, changed from r290377, llvm/trunk/test/CodeGen/MIR/X86/unexpected-size-non-generic-register-phys.mir
Removed:
llvm/trunk/test/CodeGen/MIR/X86/unexpected-size-non-generic-register-phys.mir
Modified:
llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp
Modified: llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp?rev=290378&r1=290377&r2=290378&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp (original)
+++ llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp Thu Dec 22 15:56:35 2016
@@ -1026,9 +1026,9 @@ bool MIParser::parseRegisterOperand(Mach
}
}
} else if (consumeIfPresent(MIToken::lparen)) {
- // Virtual registers may have a size with GlobalISel.
+ // Virtual registers may have a tpe with GlobalISel.
if (!TargetRegisterInfo::isVirtualRegister(Reg))
- return error("unexpected size on physical register");
+ return error("unexpected type on physical register");
LLT Ty;
if (parseLowLevelType(Token.location(), Ty))
Removed: llvm/trunk/test/CodeGen/MIR/X86/unexpected-size-non-generic-register-phys.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/MIR/X86/unexpected-size-non-generic-register-phys.mir?rev=290377&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/MIR/X86/unexpected-size-non-generic-register-phys.mir (original)
+++ llvm/trunk/test/CodeGen/MIR/X86/unexpected-size-non-generic-register-phys.mir (removed)
@@ -1,13 +0,0 @@
-# RUN: not llc -march=x86-64 -run-pass none -o /dev/null %s 2>&1 | FileCheck %s
-# This test ensures that an error is reported when a register operand is sized
-# but isn't generic, like a physical register.
-
----
-name: test_size_physreg
-registers:
-body: |
- bb.0.entry:
- liveins: %edi
- ; CHECK: [[@LINE+1]]:10: unexpected size on physical register
- %edi(32) = G_ADD i32 %edi, %edi
-...
Copied: llvm/trunk/test/CodeGen/MIR/X86/unexpected-type-phys.mir (from r290377, llvm/trunk/test/CodeGen/MIR/X86/unexpected-size-non-generic-register-phys.mir)
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/MIR/X86/unexpected-type-phys.mir?p2=llvm/trunk/test/CodeGen/MIR/X86/unexpected-type-phys.mir&p1=llvm/trunk/test/CodeGen/MIR/X86/unexpected-size-non-generic-register-phys.mir&r1=290377&r2=290378&rev=290378&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/MIR/X86/unexpected-size-non-generic-register-phys.mir (original)
+++ llvm/trunk/test/CodeGen/MIR/X86/unexpected-type-phys.mir Thu Dec 22 15:56:35 2016
@@ -8,6 +8,6 @@ registers:
body: |
bb.0.entry:
liveins: %edi
- ; CHECK: [[@LINE+1]]:10: unexpected size on physical register
- %edi(32) = G_ADD i32 %edi, %edi
+ ; CHECK: [[@LINE+1]]:10: unexpected type on physical register
+ %edi(s32) = G_ADD i32 %edi, %edi
...
More information about the llvm-commits
mailing list