[PATCH] D28041: IR: Module summary representation for type identifiers; summary test scaffolding for lowertypetests.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 10:20:33 PST 2016


tejohnson added a comment.

> In https://reviews.llvm.org/D28041#629835, @pcc wrote:
> 
>> In https://reviews.llvm.org/D28041#629749, @tejohnson wrote:
>>
>> > In https://reviews.llvm.org/D28041#629442, @mehdi_amini wrote:
>> >
>> > >
>> >
>>
>>
>> It's far from clear to me that in assembly is the right way to go. It might be for the individual summaries but not necessarily for the combined summary as it isn't really a property of any specific module.
> 
> 
> I agree, but we wouldn't want two different serializations for each of the cases (knowing that the in-memory datastructure is shared).

I was envisioning that in the combined index case it would be serialized to a separate file (similar to how we can save the combined index to a distinct bitcode file in bitcode format now), as LLVM assembly just containing the combined index (aka textual IR as Mehdi calls it below, I think we are talking about the same thing).

> 
> 
>> Given that, and also given that this format is for debugging/testing purposes only,
> 
> Isn't it true of the textual IR as well?


https://reviews.llvm.org/D28041





More information about the llvm-commits mailing list