[PATCH] D28045: [ELF] - Return file offset as address only for allocatable sections when building .gdb_index

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 08:07:00 PST 2016


aprantl added inline comments.


================
Comment at: ELF/GdbIndex.cpp:190
+    return static_cast<const ELFSectionRef &>(Sec).getOffset();
+  return 0;
 }
----------------
Would returning an Optional<uint64_t> be better here?


https://reviews.llvm.org/D28045





More information about the llvm-commits mailing list