[PATCH] D28014: Support: Add YAML I/O support for string maps.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 22 02:14:03 PST 2016


davide added inline comments.


================
Comment at: llvm/include/llvm/Support/YAMLTraits.h:1550-1557
+  static void inputOne(IO &io, StringRef key, T &v) {
+    io.mapRequired(key.str().c_str(), v[key]);
+  }
+  static void output(IO &io, T &v) {
+    for (auto &p : v)
+      io.mapRequired(p.first.c_str(), p.second);
+  }
----------------
nit: I think the variable names should start with a capital letter.


https://reviews.llvm.org/D28014





More information about the llvm-commits mailing list