[lld] r290241 - De-template DefinedSynthetic.

[Rui Ueyama via llvm-commits]

On Wed, Dec 21, 2016 at 9:12 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rui Ueyama via llvm-commits <llvm-commits at lists.llvm.org> writes:
>
>
> > Log:
> > De-template DefinedSynthetic.
>
> Thanks!
>
> >      if (!Sec)
> >        return D.Value;
> > -    if (D.Value == DefinedSynthetic<ELFT>::SectionEnd)
> > +    if (D.Value == uintX_t(-1))
>
> Having a name for the -1 was probably a good thing.
>

I changed the type of `Value` to uint64_t, so I had to change `SectionEnd`
type to uint64_t. But if I did, compiler warns on a type conversion from a
uint64_t constant -1 to uintX_t if uintX_t is a 32-bit type. That's why I
chose to remove the constant.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161221/170a2075/attachment.html>