[PATCH] D28030: [TLI] Add prototype checking for all remaining LibFuncs.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Please put a bit more care into making sure signature checks you're adding are actually correct and reasonably precise.



================
Comment at: lib/Analysis/TargetLibraryInfo.cpp:747
+  case LibFunc::ZdaPv:
+  case LibFunc::ZdlPv:
   case LibFunc::chmod:
----------------
You could probably check these a bit more precisely.


================
Comment at: lib/Analysis/TargetLibraryInfo.cpp:969
+  case LibFunc::atan2f:
+  case LibFunc::atan2l:
+  case LibFunc::atan:
----------------
atan2 is wrong...


================
Comment at: lib/Analysis/TargetLibraryInfo.cpp:1032
+  case LibFunc::sincospi_stret:
+  case LibFunc::sincospif_stret:
   case LibFunc::sinf:
----------------
sincospi_stret is wrong... I don't know the right signature off the top of my head, though.


https://reviews.llvm.org/D28030