[llvm] r290263 - Add missing includes on Windows.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 11:18:36 PST 2016


Adding more appropriate email address for Andrey.

On Wed, Dec 21, 2016 at 11:17 AM Zachary Turner <zturner at google.com> wrote:

> I can't really reproduce Andrey's original problem (_byteswap_ushort
> compiles for me just fine without this include), but if I change this to
> <cstdlib> then I assume I have to change _byteswap_ushort to
> std::_byteswap_ushort, and yet that fails.  So I'm not really sure
>
> > --- llvm/trunk/include/llvm/Support/SwapByteOrder.h (original)
> > +++ llvm/trunk/include/llvm/Support/SwapByteOrder.h Wed Dec 21 12:50:52
> 2016
> > @@ -18,6 +18,9 @@
> >  #include "llvm/Support/Compiler.h"
> >  #include "llvm/Support/DataTypes.h"
> >  #include <cstddef>
> > +#if defined(_MSC_VER) && !defined(_DEBUG)
> > +#include <stdlib.h>
>
> <cstdlib> instead of <stdlib.h>?
>
> ~Aaron
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161221/df1ded90/attachment.html>


More information about the llvm-commits mailing list