[PATCH] D28013: [LLParser] Reader vector GEP ConsantExpr correctly

Michael Kuperstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 09:31:16 PST 2016


mkuper added inline comments.


================
Comment at: lib/AsmParser/LLParser.cpp:3210
                 "getelementptr vector index has a wrong number of elements");
         }
       }
----------------
delena wrote:
> else
>   GEPWidth = ValNumEl;
> 
> If you add these 2 lines, you check that all indices have the same vector width.
Right, missed this (and, of course, I didn't add a negative test... serves me right.)
Thanks!


https://reviews.llvm.org/D28013





More information about the llvm-commits mailing list