[PATCH] D27901: [X86][[AVX512] Code size reduction in X86 by replacing EVEX with VEX encoding

[Gadi Haber via Phabricator via llvm-commits]

gadi.haber marked 3 inline comments as done.
gadi.haber added inline comments.


================
Comment at: lib/Target/X86/X86EvexToVex.cpp:141
+
+    // Check for EVEX instructions with mask or broadcast.
+    if (Desc.TSFlags & (X86II::EVEX_K | X86II::EVEX_B))
----------------
zvi wrote:
> I think it would be helpful if the comment said that in these cases the transformation is not possible because EVEX is needed to carry this information.
Updated comment:
   // Check for EVEX instructions with mask or broadcast as in these cases 
    // the EVEX prefix is needed in order to carry this information 
    // thus preventing the transformation to VEX encoding.



Repository:
  rL LLVM

https://reviews.llvm.org/D27901