[PATCH] D28010: FileOutputBuffer: support non-mmap'able file.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 00:43:09 PST 2016


ruiu added inline comments.


================
Comment at: llvm/lib/Support/FileOutputBuffer.cpp:159
+  if (fs::is_other(Stat))
+    return std::unique_ptr<FileOutputBuffer>(
+        new FileOutputBuffer(Path, Size, new NonMMappedFile(Path, Size)));
----------------
grimar wrote:
> llvm::make_unique may be ?
Why?


https://reviews.llvm.org/D28010





More information about the llvm-commits mailing list