[PATCH] D27873: Reduce the size of quarantine cache in ASAN_LOW_MEMORY configuration.

Evgeniy Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 15:51:45 PST 2016


eugenis added inline comments.


================
Comment at: lib/asan/asan_allocator.cc:235
+      // quarantine is set to 64Kb.
+      (ASAN_LOW_MEMORY) ? 64 << 10 : FIRST_32_SECOND_64(1 << 18, 1 << 20);
 
----------------
alekseyshl wrote:
> eugenis wrote:
> > 1 << 16
> Sure, but doesn't it make it a bit less cryptic using 64 and Kb (1 << 10) than 1 << 16?
it's a matter of taste, I guess
It's also consistent with other constants in this file, like 1<<18 and 1<<20.


https://reviews.llvm.org/D27873





More information about the llvm-commits mailing list